Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add node shared secrets chain explorer#411 #581

Merged

Conversation

apoorv-2204
Copy link
Contributor

@apoorv-2204 apoorv-2204 commented Sep 20, 2022

Description

It adds a new feature Node shared secrets chain explorer to UI, which includes :node_shared_secrets Tranasction type in chronological order with number of nodes authorised with arrival of that Transaction.

  • An unauthorised node will display a empty UI.
    • An unauthorised node must wait to display NSS chain explorer.
    • /explorer/chain/node_shared_secrets route with parameters(page), will still display an empty UI.
  • Though a authorised node will display
    • Total number of authorised nodes in banner
    • Number of nodes authorised w.r.t arrival of that Transaction.

Fixes # (#411)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

    • A temporary fix to Failure of faucet_Controller_test.exs using Process.sleep
  • New feature (non-breaking change which adds functionality)

    • Node shared secrets chain explorer.
  • This change requires a documentation update

    • Brief Info was added to blue banner , describing Node Shared Secrets Chain.

How Has This Been Tested?

  • Manual

    • Change in parameters > nb_pages < 1, renders page 1.
    • switch page (on page 1) when transaction reaches page limit
  • Distributed Testing

    • Authorised nodes display NSS chain
    • The un-authorised nodes should not display NSS Chain.

Screenshot_20220921_004940

Screenshot_20220921_004929

- Page parameters does not break the view, when Node not authorised.

Screenshot_20220921_005003

- Display authorised nb_of_nodes

Screenshot_20220921_005045

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@apoorv-2204 apoorv-2204 self-assigned this Sep 21, 2022
@apoorv-2204 apoorv-2204 added the UI Invole user interface label Sep 21, 2022
@apoorv-2204 apoorv-2204 marked this pull request as ready for review September 21, 2022 11:57
@Neylix Neylix self-requested a review September 22, 2022 08:05
@apoorv-2204 apoorv-2204 force-pushed the nss_explorer branch 2 times, most recently from 36b7d9f to afb7416 Compare September 26, 2022 07:04
@apoorv-2204 apoorv-2204 removed the request for review from Neylix September 27, 2022 06:09
  - Add utils.ex for total pages
  - Requested changes for NSS explorer
  - UPdated reward explorer  and reward live test
@samuelmanzanera samuelmanzanera merged commit 1060a8a into archethic-foundation:develop Sep 28, 2022
@samuelmanzanera samuelmanzanera added the feature New feature request label Oct 3, 2022
@apoorv-2204 apoorv-2204 deleted the nss_explorer branch October 7, 2022 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request UI Invole user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants